test: cover maximum multipart envelope

This commit is contained in:
Yanislav Igonin 2026-07-16 16:58:06 +04:00
parent cc7458f2c4
commit f0b8f72af6
2 changed files with 55 additions and 1 deletions

View File

@ -25,7 +25,8 @@ import (
"micrach/utils" "micrach/utils"
) )
const multipartBodyLimit = 13 * 1024 * 1024 // Reserve 1 MiB for multipart boundaries, filenames, title, and text.
const multipartBodyLimit = 4*utils.FILE_SIZE_IN_BYTES + (1 << 20)
func skipRateLimit(isLocal bool, path string) bool { func skipRateLimit(isLocal bool, path string) bool {
isRequestForStatic := strings.Contains(path, "/static") || isRequestForStatic := strings.Contains(path, "/static") ||

View File

@ -2,6 +2,7 @@ package main
import ( import (
"bytes" "bytes"
"fmt"
"io" "io"
"mime/multipart" "mime/multipart"
"net/http" "net/http"
@ -9,6 +10,7 @@ import (
"net/textproto" "net/textproto"
"os" "os"
"path/filepath" "path/filepath"
"strings"
"testing" "testing"
"github.com/gofiber/fiber/v3" "github.com/gofiber/fiber/v3"
@ -168,3 +170,54 @@ func TestMultipartBodyLimitAllowsApplicationFileSizeValidation(t *testing.T) {
t.Fatalf("status = %d, want %d", resp.StatusCode, fiber.StatusBadRequest) t.Fatalf("status = %d, want %d", resp.StatusCode, fiber.StatusBadRequest)
} }
} }
func TestMultipartBodyLimitAllowsMaximumUploadEnvelope(t *testing.T) {
var body bytes.Buffer
writer := multipart.NewWriter(&body)
if err := writer.WriteField("title", strings.Repeat("t", 100)); err != nil {
t.Fatal(err)
}
if err := writer.WriteField("text", strings.Repeat("t", 1000)); err != nil {
t.Fatal(err)
}
for fileNumber := 1; fileNumber <= 4; fileNumber++ {
header := make(textproto.MIMEHeader)
header.Set("Content-Disposition", fmt.Sprintf(`form-data; name="files"; filename="maximum-%d.png"`, fileNumber))
header.Set("Content-Type", "image/png")
part, err := writer.CreatePart(header)
if err != nil {
t.Fatal(err)
}
if _, err := part.Write(bytes.Repeat([]byte("x"), utils.FILE_SIZE_IN_BYTES)); err != nil {
t.Fatal(err)
}
}
if err := writer.Close(); err != nil {
t.Fatal(err)
}
if body.Len() >= multipartBodyLimit {
t.Fatalf("maximum valid multipart body = %d bytes, limit = %d", body.Len(), multipartBodyLimit)
}
app := fiber.New(fiber.Config{BodyLimit: multipartBodyLimit})
app.Post("/", func(c fiber.Ctx) error {
form, err := c.MultipartForm()
if err != nil {
return err
}
if got := len(form.File["files"]); got != 4 {
return fiber.NewError(fiber.StatusInternalServerError, fmt.Sprintf("files = %d, want 4", got))
}
return c.SendStatus(fiber.StatusNoContent)
})
req := httptest.NewRequest(http.MethodPost, "/", &body)
req.Header.Set(fiber.HeaderContentType, writer.FormDataContentType())
resp, err := app.Test(req)
if err != nil {
t.Fatal(err)
}
defer resp.Body.Close()
if resp.StatusCode != fiber.StatusNoContent {
t.Fatalf("status = %d, want %d", resp.StatusCode, fiber.StatusNoContent)
}
}